-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create "biome" hook, preserve "rome" hook as alias #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oxcabe, could you please remove all the code formatting changes? The diff should be readable and contain just the changes you're proposing. Thanks!
Sure thing, I'm not even sure when the files got formatted 😅 |
17f3ac6
to
05c3a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the better approach here would be to use mkRenamedOptionModule
to rename rome -> biome
. You get the alias and people will be prompted to switch.
If you feel like an alias (with no warning) is more appropriate for now, then you can use mkAliasOptionModule
instead.
There's no need to have both rome
and biome
in config.hooks
.
c0b916f
to
8b255d0
Compare
I know it's failing as of my last commit. Currently trying to figure out by myself what am I doing wrong and why 👍🏼 |
8b255d0
to
8f2d990
Compare
Implemented this approach. For some reason, the deprecation warning is not appearing when enabling the hook: rome.enable = true;
I can't seem to make it work without having
|
Co-authored-by: sander <[email protected]>
From the failing build:
What should I do here? |
See if you can move that rec around to stop it from reformatting everything. If not, then commit the formatting changes. |
Ready! |
This PR does the following:
Fixes #428.